Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(aws_eks_cluster_auth): update outdated note on resource imports #32718

Merged
merged 1 commit into from
Jul 27, 2023
Merged

docs(aws_eks_cluster_auth): update outdated note on resource imports #32718

merged 1 commit into from
Jul 27, 2023

Conversation

TPXP
Copy link
Contributor

@TPXP TPXP commented Jul 27, 2023

Description

The documentation for eks_cluster_auth has a scary warning referring to a terraform limitation that has been solved since. I suggest we mention in the note that only terraform versions <1.3.0 are affected by the problem.

Relations/References

Output from Acceptance Testing

N/A, this is a documentation change

@TPXP
docs(aws_eks_cluster_auth): update outdated note on resource imports
0e4fd51 
The issue this note refers to has been solved since, clarify recent
Terraform versions are not impacted.

refs:
* hashicorp/terraform#13018 (comment)
* hashicorp/terraform#27934
* hashicorp/terraform#31283
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2023
github-actions[bot]
github-actions bot reviewed Jul 27, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @TPXP 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

ewbankkit
ewbankkit approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@TPXP Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 27, 2023
@ewbankkit ewbankkit merged commit a42b070 into hashicorp:main Jul 27, 2023
39 checks passed
@github-actions github-actions bot added this to the v5.10.0 milestone Jul 27, 2023
@github-actions
Copy link

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TPXP @ewbankkit